Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Jan 9, 2026

The label-selector flag needs to get exposed as a config value, and the leader election needs to be independent per label.

@fwiesel fwiesel requested a review from notandy January 9, 2026 14:29
Copy link
Contributor

@toanju toanju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Chart version require a bump?

@fwiesel fwiesel force-pushed the label-selector-exposed branch from e4cd3d8 to 360e26a Compare January 19, 2026 09:01
@fwiesel
Copy link
Contributor Author

fwiesel commented Jan 19, 2026

I've bumped the chart version.

@fwiesel fwiesel requested a review from toanju January 19, 2026 09:01
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd/main.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

The label-selector flag needs to get exposed as a config value,
and the leader election needs to be independent per label.
@fwiesel fwiesel merged commit 21dd386 into main Jan 19, 2026
6 checks passed
@fwiesel fwiesel deleted the label-selector-exposed branch January 19, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants